On Tue, Jan 2, 2024 at 1:30 PM Hans de Goede <hdegoede@xxxxxxxxxx> wrote: > On 1/2/24 01:33, Andy Shevchenko wrote: > > On Sun, Dec 31, 2023 at 12:31 PM Hans de Goede <hdegoede@xxxxxxxxxx> wrote: ... > >> +static const struct attribute_group dbg_attr_group = { > >> + .attrs = dbg_attrs, > >> +}; > >> > >> +const struct attribute_group *dbg_attr_groups[] = { > >> + &dbg_attr_group, > >> + NULL > >> +}; > > > > ATTRIBUTE_GROUPS() > > I deliberately wrote this out (had to write this out) > instead of using ATTRIBUTE_GROUPS() because ATTRIBUTE_GROUPS() > makes the groups variable static and here it gets used > in another file then where it is declared. I see, but can it be refactored / does it make sense to refactor that it becomes visible only in one module? -- With Best Regards, Andy Shevchenko