On Sun, Dec 31, 2023 at 12:31 PM Hans de Goede <hdegoede@xxxxxxxxxx> wrote: ... > -Remove the unnecessary pcim_iounmap_regions() those are devm managed > so they will get cleaned up automatically on an error exit from probe() Yeah, yeah, but to eliminate unneeded churn in your series, please, do this early enough (before previous patch). -- With Best Regards, Andy Shevchenko