On Sun, Oct 31, 2010 at 6:18 PM, Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx> wrote: > On Sunday, October 31, 2010 10:51:21 am Stefan Richter wrote: >> Commit 9f470095068e "Input: media/IR - switch to using new keycode >> interface" added the following build warning: >> >> drivers/media/IR/ir-keytable.c: In function 'ir_getkeycode': >> drivers/media/IR/ir-keytable.c:363: warning: 'retval' may be used uninitialized in this function >> >> It is due to an actual bug but I don't know the fix. >> > > The patch below should fix it. I wonder if Linus released -rc1 yet... Looks like it missed rc1. > Input: ir-keytable - fix uninitialized variable warning > > From: Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx> > > We were forgetting to set up proper return value in success path causing > ir_getkeycode() to fail intermittently: > > drivers/media/IR/ir-keytable.c: In function 'ir_getkeycode': > drivers/media/IR/ir-keytable.c:363: warning: 'retval' may be used > uninitialized in this function > > Reported-by: Stefan Richter <stefanr@xxxxxxxxxxxxxxxxx> > Signed-off-by: Dmitry Torokhov <dtor@xxxxxxx> Acked-by: Jarod Wilson <jarod@xxxxxxxxxx> -- Jarod Wilson jarod@xxxxxxxxxxxx -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
