>On Sat, 30 Dec 2023 10:46:42 +0100, Alex Bee <knaerzche@xxxxxxxxx> wrote: >if the RK3568 and RK3588 variants match, patch [1/3] is not necessary. Just >document a additional compatible in a similar way it's being done for >rk3188/rk3066 or rk3228/rk3399. >If there are ever differences we don't know about yet, a additional variant >can still be added in the driver. Hi Alex, I did try to not touching hantro driver code and just enabling the node in devicetree by a compatible property like: compatible = "rockchip,rk3588-vpu", "rockchip,rk3568-vpu"; but the hantro g1 node is not binded by hantro driver. I guess that is because hantro driver is already binded to the hantro av1 vpu on rk3588, so I added patch[1/3] to make it work. Jianfeng
