RE: [PATCH 01/15] media: s5p-mfc: drop unused static s5p_mfc_cmds

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




> -----Original Message-----
> From: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
> Sent: 24 December 2023 21:14
> To: Marek Szyprowski <m.szyprowski@xxxxxxxxxxx>; Andrzej Hajda
> <andrzej.hajda@xxxxxxxxx>; Mauro Carvalho Chehab
> <mchehab@xxxxxxxxxx>
> Cc: Aakarsh Jain <aakarsh.jain@xxxxxxxxxxx>; linux-fsd@xxxxxxxxxx; linux-
> samsung-soc@xxxxxxxxxxxxxxx; Smitha T Murthy
> <smithatmurthy@xxxxxxxxx>; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; linux-
> media@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; Krzysztof Kozlowski
> <krzysztof.kozlowski@xxxxxxxxxx>
> Subject: [PATCH 01/15] media: s5p-mfc: drop unused static s5p_mfc_cmds
> 
> File-scope static variable "s5p_mfc_cmds" is not read after assignment, thus
> it can be dropped entirely.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
> ---
>  drivers/media/platform/samsung/s5p-mfc/s5p_mfc_cmd.c | 8 ++------
>  1 file changed, 2 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/media/platform/samsung/s5p-mfc/s5p_mfc_cmd.c
> b/drivers/media/platform/samsung/s5p-mfc/s5p_mfc_cmd.c
> index 774c573dc075..196d8c99647b 100644
> --- a/drivers/media/platform/samsung/s5p-mfc/s5p_mfc_cmd.c
> +++ b/drivers/media/platform/samsung/s5p-mfc/s5p_mfc_cmd.c
> @@ -12,14 +12,10 @@
>  #include "s5p_mfc_cmd_v5.h"
>  #include "s5p_mfc_cmd_v6.h"
> 
> -static struct s5p_mfc_hw_cmds *s5p_mfc_cmds;
> -
>  void s5p_mfc_init_hw_cmds(struct s5p_mfc_dev *dev)  {
>  	if (IS_MFCV6_PLUS(dev))
> -		s5p_mfc_cmds = s5p_mfc_init_hw_cmds_v6();
> +		dev->mfc_cmds = s5p_mfc_init_hw_cmds_v6();
>  	else
> -		s5p_mfc_cmds = s5p_mfc_init_hw_cmds_v5();
> -
> -	dev->mfc_cmds = s5p_mfc_cmds;
> +		dev->mfc_cmds = s5p_mfc_init_hw_cmds_v5();
>  }
> 
> --
> 2.34.1

Reviewed-by: Aakarsh Jain <aakarsh.jain@xxxxxxxxxxx>

Thanks!






[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux