On 12/19/2023 3:03 AM, Konrad Dybcio wrote:
>
>
> On 12/18/23 12:32, Dikshita Agarwal wrote:
>> Shared queues are used for communication between driver and firmware.
>> There are 3 types of queues:
>> Command queue - driver to write any command to firmware.
>> Message queue - firmware to send any response to driver.
>> Debug queue - firmware to write debug message.
>>
>> Above queues are initialized and configured to firmware during probe.
>>
>> Signed-off-by: Dikshita Agarwal <quic_dikshita@xxxxxxxxxxx>
>> ---
> [...]
>
>> + ret = hfi_queue_init(core->dev, &core->iface_q_table, &core->sfr,
>> + &core->command_queue, &core->message_queue,
>> + &core->debug_queue, core);
>> + if (ret) {
>> + dev_err_probe(core->dev, ret,
>> + "%s: interface queues init failed\n", __func__);
>> + goto err_vdev_unreg;
>> + }
>> +
>> return ret;
> Like before, you're suppose to return dev_err_probe
Sure, will fix all such instances.
>
> Konrad
