On 18.12.2023 12:32, Dikshita Agarwal wrote: > Implement iris v4l2_ctrl_ops - s_ctrl and g_volatile_ctrl. > > Core capability structure has all the supported capabilities > for all supported codecs. Initializes instance capability > from core capability based on the codec type. > > Add following to each capability: > Children: define dependencies for a specific capability. > Adjust: define function to adjust the value of capability > based on client configuration or dependency with > other capability. > Set: define function to set the adjusted value to firmware. > > Prepare dependency graph for all inter-dependent capabilities. > This is used to adjust the value of capabilities and set the > same to firmware. > > Signed-off-by: Dikshita Agarwal <quic_dikshita@xxxxxxxxxxx> > --- [...] > +static inline bool are_all_childrens_visited(struct plat_inst_cap *cap, > + bool lookup[INST_CAP_MAX]) he's making a list, he's checking it twice.. I still think moving to a predefined config struct instead would be a good idea Konrad
