On Tue, Dec 12, 2023 at 05:08:38PM +0100, Uwe Kleine-König wrote: > Hello Sean, > > On Tue, Dec 12, 2023 at 08:34:04AM +0000, Sean Young wrote: > > @@ -169,6 +179,7 @@ static int bcm2835_pwm_suspend(struct device *dev) > > { > > struct bcm2835_pwm *pc = dev_get_drvdata(dev); > > > > + clk_rate_exclusive_put(pc->clk); > > clk_disable_unprepare(pc->clk); > > I thought this was the remove function, but that's suspend. Adding > clk_rate_exclusive_put() there is wrong. Nice catch - fixed in v9. Sean