Hi! Rockchip ISP1 is broken for me on a custom rk3399-based board in the latest media_stage. Relevant dmesg fragment: rkisp1 ff910000.isp0: Adding to iommu group 2 genirq: Flags mismatch irq 42. 00000004 (rkisp1) vs. 00000084 (ff914000.iommu) rkisp1 ff910000.isp0: request irq failed: -16 rkisp1: probe of ff910000.isp0 failed with error -16 rkisp1 ff920000.isp1: Adding to iommu group 3 genirq: Flags mismatch irq 43. 00000004 (rkisp1) vs. 00000084 (ff924000.iommu) rkisp1 ff920000.isp1: request irq failed: -16 rkisp1: probe of ff920000.isp1 failed with error -16 According to rk3399.dtsi, isp interrupts are shared with correponding mmu interrupts (isp0 with isp0_mmu, isp1 with isp1_mmu), so the subject commit breaks devm_request_irq. Reverting it fixes the issue for me. If I'm just missing something, sorry for the noise. -- Best regards, Mikhail Rudenko