Hi Sakari, On Thu, Dec 14, 2023 at 08:36:48AM +0000, Sakari Ailus wrote: > Hi Tommaso, > > On Thu, Dec 14, 2023 at 09:26:01AM +0100, Tommaso Merciai wrote: > > Hi Laurent, > > > > Applying this patch I received the following error from checkpatch.pl > > maybe is a false positive or maybe I miss somenthing. Btw hope this help. :) > > > > Applying: media: v4l2-subdev: Store frame interval in subdev state > > No codespell typos will be found - file '/usr/share/codespell/dictionary.txt': No such file or directory > > ERROR: Macros with complex values should be enclosed in parentheses > > #135: FILE: include/media/v4l2-subdev.h:1411: > > +#define v4l2_subdev_state_get_interval(state, pad, ...) \ > > + __v4l2_subdev_state_gen_call(interval, ##__VA_ARGS__, , _pad) \ > > + (state, pad, ##__VA_ARGS__) > > > > ERROR: space prohibited before that ',' (ctx:WxW) > > #136: FILE: include/media/v4l2-subdev.h:1412: > > + __v4l2_subdev_state_gen_call(interval, ##__VA_ARGS__, , _pad) \ > > Checkpatch can't handle well macros that do something as unusual as this > one and it's not really worth fixing it for a few rare cases. This macro > generates a name of the function (or macro) and the two consecutive commas > (separated by a space as they should, think of it as an empty argument) are > there intentionally. Thanks for the explanation, Regards, Tommaso > > -- > Regards, > > Sakari Ailus
