Hi Laurent, Unfortunately this series now clashes with the just-merged alvium sensor driver, so it has to be rebased. Regards, Hans On 13/12/2023 15:04, Laurent Pinchart wrote: > Hello, > > This patch series improves frame interval handling in the V4L2 subdev > in-kernel and userspace APIs. > > Frame interval are exposed to userspace on pads and streams, but the > frame interval handling is currently implemented through a v4l2_subdev > video operation, without involving the subdev state. This makes frame > intervals a second class citizen compared to formats and selection > rectangles. > > Patch 1/8 is a preparatory fix that Tomi posted today, and on which this > series depends. I've included here for completeness. > > Patch 2/8 then starts the work by addressing the first issue, namely the > frame interval operations being video ops. This requires touching all > the drivers using frame intervals. > > Patch 3/8 adds a 'which' field to the subdev frame interval userspace > API, allowing frame intervals to be tried the same way formats and > selection rectangles can. Again, the same drivers need to be touched to > preserve their current behaviour. > > Patch 4/8 adds support for storing the frame interval in the subdev > state, alongside the formats and selection rectangles, with similar > accessors and helper functions. > > Patches 5/8 to 7/8 address small issues in the subdev uAPI documentation > that were raised during review of v2 or discovered when working on v3. > > Finally, patch 8/8 demonstrates how this is used in drivers, with the > thp7312 driver serving as an example. > > Compared to v4, review comments have been taken into account for patch > 3/8, Reviewed-by tags added, and the series rebased on the latest stage > master branch. > > I have limited the recipients on this version to avoid spamming all > drivers maintainers, as they have had a chance to review patches 2/8 and > 3/8, and I understand v5 will be final and get before the end of this > week. > > Laurent Pinchart (7): > media: v4l2-subdev: Turn .[gs]_frame_interval into pad operations > media: v4l2-subdev: Add which field to struct > v4l2_subdev_frame_interval > media: v4l2-subdev: Store frame interval in subdev state > media: docs: uAPI: Clarify error documentation for invalid 'which' > value > media: docs: uAPI: Expand error documentation for invalid 'which' > value > media: docs: uAPI: Fix documentation of 'which' field for routing > ioctls > media: i2c: thp7312: Store frame interval in subdev state > > Tomi Valkeinen (1): > media: v4l: subdev: Move out subdev state lock macros outside > CONFIG_MEDIA_CONTROLLER > > .../v4l/vidioc-subdev-enum-frame-interval.rst | 9 +- > .../v4l/vidioc-subdev-enum-frame-size.rst | 7 +- > .../v4l/vidioc-subdev-enum-mbus-code.rst | 7 +- > .../media/v4l/vidioc-subdev-g-client-cap.rst | 5 + > .../media/v4l/vidioc-subdev-g-crop.rst | 7 +- > .../media/v4l/vidioc-subdev-g-fmt.rst | 5 +- > .../v4l/vidioc-subdev-g-frame-interval.rst | 20 +- > .../media/v4l/vidioc-subdev-g-routing.rst | 7 +- > .../media/v4l/vidioc-subdev-g-selection.rst | 7 +- > drivers/media/i2c/adv7180.c | 14 +- > drivers/media/i2c/et8ek8/et8ek8_driver.c | 20 +- > drivers/media/i2c/imx214.c | 16 +- > drivers/media/i2c/imx274.c | 62 +++-- > drivers/media/i2c/max9286.c | 28 ++- > drivers/media/i2c/mt9m111.c | 28 ++- > drivers/media/i2c/mt9m114.c | 28 ++- > drivers/media/i2c/mt9v011.c | 32 ++- > drivers/media/i2c/mt9v111.c | 30 ++- > drivers/media/i2c/ov2680.c | 14 +- > drivers/media/i2c/ov5640.c | 30 ++- > drivers/media/i2c/ov5648.c | 66 ++--- > drivers/media/i2c/ov5693.c | 14 +- > drivers/media/i2c/ov6650.c | 30 ++- > drivers/media/i2c/ov7251.c | 20 +- > drivers/media/i2c/ov7670.c | 30 ++- > drivers/media/i2c/ov772x.c | 28 ++- > drivers/media/i2c/ov7740.c | 40 ++- > drivers/media/i2c/ov8865.c | 58 +++-- > drivers/media/i2c/ov9650.c | 28 ++- > drivers/media/i2c/s5c73m3/s5c73m3-core.c | 28 ++- > drivers/media/i2c/s5k5baf.c | 34 ++- > drivers/media/i2c/thp7312.c | 160 ++++++------ > drivers/media/i2c/tvp514x.c | 41 ++-- > drivers/media/usb/em28xx/em28xx-video.c | 6 +- > drivers/media/v4l2-core/v4l2-common.c | 8 +- > drivers/media/v4l2-core/v4l2-subdev.c | 130 +++++++--- > .../media/atomisp/i2c/atomisp-gc0310.c | 14 +- > .../media/atomisp/i2c/atomisp-gc2235.c | 14 +- > .../media/atomisp/i2c/atomisp-mt9m114.c | 14 +- > .../media/atomisp/i2c/atomisp-ov2722.c | 14 +- > .../staging/media/atomisp/pci/atomisp_cmd.c | 4 +- > .../staging/media/atomisp/pci/atomisp_ioctl.c | 4 +- > drivers/staging/media/imx/imx-ic-prp.c | 28 ++- > drivers/staging/media/imx/imx-ic-prpencvf.c | 28 ++- > drivers/staging/media/imx/imx-media-capture.c | 6 +- > drivers/staging/media/imx/imx-media-csi.c | 28 ++- > drivers/staging/media/imx/imx-media-vdic.c | 28 ++- > drivers/staging/media/tegra-video/csi.c | 16 +- > include/media/v4l2-common.h | 4 +- > include/media/v4l2-subdev.h | 231 +++++++++++------- > include/uapi/linux/v4l2-subdev.h | 15 +- > 51 files changed, 1019 insertions(+), 526 deletions(-) > > > base-commit: 09b4195021be69af1e1936cca995712a6d0f2562
