Hello On Tue, Dec 12, 2023 at 11:05:48AM +0000, Sakari Ailus wrote: > Hi Hans, > > On Tue, Dec 12, 2023 at 10:09:31AM +0100, Hans Verkuil wrote: > > On 12/12/2023 09:16, Sakari Ailus wrote: > > > Hi Hans, Mauro, > > > > > > Here's a nice set of some fixes as well as new drivers that some of which, > > > in turn, depend on the fixes. In particular, there are a few sensors > > > (imx290 in particular) that have little endian registers, either just some > > > or all, and this was missed in V4L2 CCI conversion earlier on. Another > > > driver also needs these CCI_*LE() macros later in the set. > > > > > > There are new drivers for Galaxycore gc0308, Omnivision ov64a30 camera > > > sensor as well as Avnet Alvium camera modules. > > > > > > Miscellaneous fixes exist for imx335, imx214, imx415, ov2740 as well as the > > > IPU bridge. > > > > > > Documentation improvements for camera sensors are included, too. > > > > > > Please pull. [snip] > > > > 0037-media-dt-bindings-Add-OmniVision-OV64A40.patch: > > > > WARNING: Co-developed-by and Signed-off-by: name/email do not match > > #11: > > Co-developed-by: Lee Jackson <lee.jackson@xxxxxxxxxxx> > > Signed-off-by: Jacopo Mondi <jacopo.mondi@xxxxxxxxxxxxxxxx> > > > > 0038-media-i2c-Add-driver-for-OmniVision-OV64A40.patch: > > > > WARNING: Co-developed-by and Signed-off-by: name/email do not match > > #11: > > Co-developed-by: Lee Jackson <lee.jackson@xxxxxxxxxxx> > > Signed-off-by: Jacopo Mondi <jacopo.mondi@xxxxxxxxxxxxxxxx> > > > > 0039-media-i2c-imx415-Convert-to-new-CCI-register-access-.patch: > > I'll ask Jacopo to fix these. > I noticed these while runnig checkpatch, but I thought it was checkpatch beeing too picky. I added the Co-developed-by tag because I was asked by dt maintainers. Before I had only Lee's Signed-off-by, but it seems now I have to add both.. How would you like to proceed ? > But overall, apart from the missing SoB lines (I missed this while looking > at the long list of warnings the patches produce), is there something that > prevents merging this? I agree there are bugs, but this all is still found > at the time the PR has been sent which makes remedying them very difficult. > > > > > CHECK: Alignment should match open parenthesis > > #461: FILE: drivers/media/i2c/imx415.c:462: > > + cci_write(sensor->regmap, IMX415_BLKLEVEL, > > + IMX415_BLKLEVEL_DEFAULT, &ret); > > -- > Regards, > > Sakari Ailus >
