Hi Tommaso,
On Tue, Dec 12, 2023 at 01:17:45PM +0100, Tommaso Merciai wrote:
> Hi Sakari,
> Just a clarification about the following warnings:
>
> Fixed on my side with:
>
> CHECK: Assignment operator '=' should be on the previous line
>
> - alvium->is_mipi_fmt_avail[ALVIUM_BIT_YUV420_8_LEG]
> - = avail_fmt->yuv420_8_leg;
> + alvium->is_mipi_fmt_avail[ALVIUM_BIT_YUV420_8_LEG] =
> + avail_fmt->yuv420_8_leg;
This one seems good.
>
> CHECK: line length of 81 exceeds 80 columns
> #1085: FILE: drivers/media/i2c/alvium-csi2.c:1085:
> + if (!alvium->is_mipi_fmt_avail[alvium_csi2_fmts[fmt].fmt_av_bit])
>
> CHECK: line length of 81 exceeds 80 columns
> #1102: FILE: drivers/media/i2c/alvium-csi2.c:1102:
> + if (!alvium->is_mipi_fmt_avail[alvium_csi2_fmts[fmt].fmt_av_bit])
>
>
> Fixed on my side with:
>
> /* Create the alvium_csi2 fmt array from formats available */
> for (fmt = 0; fmt < ALVIUM_NUM_SUPP_MIPI_DATA_FMT; fmt++) {
> - if (!alvium->is_mipi_fmt_avail[alvium_csi2_fmts[fmt].fmt_av_bit])
> + if (!alvium->is_mipi_fmt_avail[alvium_csi2_fmts[fmt]
> + .fmt_av_bit])
I wouldn't introduce a line break in these two cases.
> continue;
>
> Can be ok for you?
> If yes I'm going to prepare the patch on top of your media_tree/master
> branch.
Ack.
--
Sakari Ailus
