Hi Sakari, Am Dienstag, 12. Dezember 2023, 12:37:37 CET schrieb Sakari Ailus: > Hi Alexander, > > On Tue, Dec 05, 2023 at 10:05:56AM +0100, Alexander Stein wrote: > > Complete the list from "INCK Setting" section in IMX415-AAQR-C > > (Rev. E19504, 2019/05/21) > > > > Signed-off-by: Alexander Stein <alexander.stein@xxxxxxxxxxxxxxx> > > Could you address these smatch warnings, and run > > ./scripts/checkpatch.pl --strict --max-line-length=80 > > on the patches? > > drivers/media/i2c/imx415.c:402:30: warning: decimal constant 2376000000 is > between LONG_MAX and ULONG_MAX. For C99 that means long long, C90 compilers > are very likely to produce unsigned long (and a > warning) here > drivers/media/i2c/imx415.c:417:30: warning: decimal constant 2376000000 is > between LONG_MAX and ULONG_MAX. For C99 that means long long, C90 compilers > are very likely to produce unsigned long (and a > warning) here > drivers/media/i2c/imx415.c:432:30: warning: decimal constant 2376000000 is > between LONG_MAX and ULONG_MAX. For C99 that means long long, C90 compilers > are very likely to produce unsigned long (and a > warning) here Interesting, I don't have these warnings here. Is this some more recent checkpath.pl not in next? I've addressed this and some 80 char length warnings as well. As I've sent out v2 this morning already, I'm waiting a bit more bevore v3. Best regards, Alexander -- TQ-Systems GmbH | Mühlstraße 2, Gut Delling | 82229 Seefeld, Germany Amtsgericht München, HRB 105018 Geschäftsführer: Detlef Schneider, Rüdiger Stahl, Stefan Schneider http://www.tq-group.com/
