On Dec 12, 2023 at 13:24:42 +0530, Jai Luthra wrote:
> Hi Julien,
>
> Thanks for the patch.
>
> Please make sure to add the media maintainers in To/Cc, you can use
> get_maintainers.pl script for the full list.
>
> On Dec 08, 2023 at 16:22:53 +0100, Julien Massot wrote:
> > On some subdev the fwnode is the device node and not the endpoint node.
> > Using the subdev fwnode doesn't allow to fetch the subdev
> > pad we are connected to when the remote subdev has multiple
> > output pads.
> >
> > Signed-off-by: Julien Massot <julien.massot@xxxxxxxxxxxxx>
> > ---
> > drivers/media/platform/cadence/cdns-csi2rx.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/media/platform/cadence/cdns-csi2rx.c b/drivers/media/platform/cadence/cdns-csi2rx.c
> > index b751227fc8a0..b9356cc7a192 100644
> > --- a/drivers/media/platform/cadence/cdns-csi2rx.c
> > +++ b/drivers/media/platform/cadence/cdns-csi2rx.c
> > @@ -464,7 +464,7 @@ static int csi2rx_async_bound(struct v4l2_async_notifier *notifier,
> > struct csi2rx_priv *csi2rx = v4l2_subdev_to_csi2rx(subdev);
> >
> > csi2rx->source_pad = media_entity_get_fwnode_pad(&s_subdev->entity,
> > - s_subdev->fwnode,
> > + asd->match.fwnode,
> > MEDIA_PAD_FL_SOURCE);
>
> LGTM, this also fixes a similar issue I was seeing with getting fwnode
> pad ds90ub960 source which has multiple output pads.
>
> Reviewed-by: Jai Luthra <j-luthra@xxxxxx>
This should probably carry a fixes tag as well:
Fixes: 1fc3b37f34f69 ("media: v4l: cadence: Add Cadence MIPI-CSI2 RX driver")
>
> > if (csi2rx->source_pad < 0) {
> > dev_err(csi2rx->dev, "Couldn't find output pad for subdev %s\n",
> > --
> > 2.43.0
> >
>
> --
> Thanks,
> Jai
>
> GPG Fingerprint: 4DE0 D818 E5D5 75E8 D45A AFC5 43DE 91F9 249A 7145
--
Thanks,
Jai
GPG Fingerprint: 4DE0 D818 E5D5 75E8 D45A AFC5 43DE 91F9 249A 7145
Attachment:
signature.asc
Description: PGP signature
