Em 29-10-2010 04:29, Jarkko Nikula escreveu: > Hi > > On Sun, 17 Oct 2010 22:34:32 +0200 > Mauro Carvalho Chehab <mchehab@xxxxxxxxxx> wrote: > >> This is an automatic generated email to let you know that the following patch were queued at the >> http://git.linuxtv.org/media_tree.git tree: >> >> Subject: [media] radio-si4713: Add regulator framework support >> Author: Jarkko Nikula <jhnikula@xxxxxxxxx> >> Date: Tue Sep 21 05:49:43 2010 -0300 >> >> Convert the driver to use regulator framework instead of set_power callback. >> This with gpio_reset platform data provide cleaner way to manage chip VIO, >> VDD and reset signal inside the driver. >> >> Signed-off-by: Jarkko Nikula <jhnikula@xxxxxxxxx> >> Cc: Eduardo Valentin <eduardo.valentin@xxxxxxxxx> >> Signed-off-by: Mauro Carvalho Chehab <mchehab@xxxxxxxxxx> >> >> drivers/media/radio/si4713-i2c.c | 74 ++++++++++++++++++++++++++++++++------ >> drivers/media/radio/si4713-i2c.h | 5 ++- >> 2 files changed, 67 insertions(+), 12 deletions(-) >> >> --- >> >> http://git.linuxtv.org/media_tree.git?a=commitdiff;h=d455b639c1fb09f8ea888371fb6e04b490e115fb >> > Was this patch lost somewhere? I don't see it in mainline for 2.6.37 > but e.g. 85c55ef is there. > > I had to remove it from my queue, as the patch broke compilation: http://git.linuxtv.org/media_tree.git?a=commit;h=350df81ebaccc651fa4dfad27738db958e067ded What's the sense of adding a patch that breaks a driver? Even assuming that you would later send a patch fixing it, there are still some problems: 1) A latter patch will break git bisect; 2) A broken driver means that I can't test anymore if there are any other problems on other drivers. So, please test your patches against breakages, before sending them to me. Thanks, Mauro -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
