Re: [PATCH v3 1/4] staging: vc04_services: Drop vchiq_log_error() in favour of dev_err

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Umang,

Am 07.12.23 um 09:41 schrieb Umang Jain:
Hi Stefan

On 12/7/23 3:04 AM, Stefan Wahren wrote:
Hi Umang,

Am 06.12.23 um 06:27 schrieb Umang Jain:
Hi Stefan

On 12/6/23 1:02 AM, Stefan Wahren wrote:
Hi Umang,

Am 05.12.23 um 09:41 schrieb Umang Jain:
Drop vchiq_log_error() macro which wraps dev_dbg(). Introduce the
usage
of dev_err() directly.
sorry, i missed to review the last change. So the change won't be that
trivial.

All the changes you said are valid and I have taken a note of it.

However, I think it would best that if we can address them in a
separate series on top of this (and I will do it). It would seem to be
streamlined on top of this.
i would address the comments as separate patches and then finally
convert the trivial rest with such a patch within one series. This
avoids unnecessary changes and reviewes. But that's just my opinion.


Series is merged by Greg KH (Thank you).

Do you have more comments on 3/4 and 4/4 or are they waiting on your
review queue. Let me know so that I can prepare a follow up series in
-one- go.
i was busy. I will look at the rest tomorrow.

Best regards

thanks!
Best regards







[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux