On 05/12/2023 12:01, Sakari Ailus wrote:
> Hi Krzysztof,
>
> Thanks for the patch.
>
> On Tue, Dec 05, 2023 at 09:48:35AM +0100, Krzysztof Kozlowski wrote:
>> Bindings and Linux driver require two link frequencies, so correct the
>> example:
>>
>> ov8856.example.dtb: camera@10: port:endpoint:link-frequencies:0: [360000000] is too short
>>
>> Fixes: 066a94e28a23 ("media: dt-bindings: media: Use graph and video-interfaces schemas")
>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
>> ---
>> Documentation/devicetree/bindings/media/i2c/ov8856.yaml | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/Documentation/devicetree/bindings/media/i2c/ov8856.yaml b/Documentation/devicetree/bindings/media/i2c/ov8856.yaml
>> index 57f5e48fd8e0..bd1a55d767e7 100644
>> --- a/Documentation/devicetree/bindings/media/i2c/ov8856.yaml
>> +++ b/Documentation/devicetree/bindings/media/i2c/ov8856.yaml
>> @@ -126,7 +126,7 @@ examples:
>> wcam_out: endpoint {
>> remote-endpoint = <&mipi_in_wcam>;
>> data-lanes = <1 2 3 4>;
>> - link-frequencies = /bits/ 64 <360000000>;
>> + link-frequencies = /bits/ 64 <360000000 180000000>;
>
> There indeed seems to be a problem with the example as far as the bindings
> are concerned but the primary issue seems to be in the bindings. Both of
> these frequencies have significance from driver point of view only while
> the device itself supports a (wider) range.
>
> How about removing maxItems and items from the bindings instead?
Yeah, it makes sense.
Best regards,
Krzysztof
