Re: [PATCH] media: nxp: isi: Check whether pad is non-NULL before access

[Marek Vasut <marex@xxxxxxx>]

On 12/2/23 03:27, Fabio Estevam wrote:
> On Fri, Dec 1, 2023 at 12:06 PM Marek Vasut <marex@xxxxxxx> wrote:
>
> >          pad = media_pad_remote_pad_first(&xbar->pads[sink_pad]);
> > -       sd = media_entity_to_v4l2_subdev(pad->entity);
> > +       if (!pad) {
> > +               dev_dbg(xbar->isi->dev,
>
> Maybe dev_err() here instead?

That dev_dbg() is aligned with the prints in the rest of the function 
and it's not like kernel should do dev_err() into kernel log every time 
userspace does something wrong.

> Anyway:
>
> Reviewed-by: Fabio Estevam <festevam@xxxxxxxxx>

Thanks !