On Wed, 27 Oct 2010, Baruch Siach wrote: > When SOCAM_PCLK_SAMPLE_FALLING, just leave CSICR1_REDGE unset, otherwise we get > the inverted behaviour. Seems logical to me, that if this is true, then you need the inverse: if (!(common_flags & SOCAM_PCLK_SAMPLE_FALLING)) csicr1 |= CSICR1_INV_PCLK; Thanks Guennadi > > Signed-off-by: Baruch Siach <baruch@xxxxxxxxxx> > --- > drivers/media/video/mx2_camera.c | 2 -- > 1 files changed, 0 insertions(+), 2 deletions(-) > > diff --git a/drivers/media/video/mx2_camera.c b/drivers/media/video/mx2_camera.c > index 3ea2ec0..02f144f 100644 > --- a/drivers/media/video/mx2_camera.c > +++ b/drivers/media/video/mx2_camera.c > @@ -811,8 +811,6 @@ static int mx2_camera_set_bus_param(struct soc_camera_device *icd, > > if (common_flags & SOCAM_PCLK_SAMPLE_RISING) > csicr1 |= CSICR1_REDGE; > - if (common_flags & SOCAM_PCLK_SAMPLE_FALLING) > - csicr1 |= CSICR1_INV_PCLK; > if (common_flags & SOCAM_VSYNC_ACTIVE_HIGH) > csicr1 |= CSICR1_SOF_POL; > if (common_flags & SOCAM_HSYNC_ACTIVE_HIGH) > -- > 1.7.1 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-media" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html > --- Guennadi Liakhovetski, Ph.D. Freelance Open-Source Software Developer http://www.open-technology.de/ -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
