* Hans Verkuil (hverkuil-cisco@xxxxxxxxx) wrote: > Dave, thank you for your detailed bttv bug report: > > https://lore.kernel.org/linux-media/ZVK_3UmvmOaCv1tc@gallifrey/ > > It was very helpful and I managed to reproduce these issues. > > This patch series fixes them. > > The first patch is unrelated, just something I noticed while > debugging this. > > The second patch adds back the old bttv behavior of storing the > frame counter in the last 4 bytes of the vbi payload when using > read(). > > The final patch fixes the vbi read() behavior where it was > alternating between valid data and a zeroed buffer. > > I'd appreciate it if you can test this before Dec 11 since I > plan to merge on Dec 11 if I don't hear anything. Sure, I'll get on it. Dave > Regards, > > Hans > > Hans Verkuil (3): > media: bttv: start_streaming should return a proper error code > media: bttv: add back vbi hack > media: videobuf2: request more buffers for vb2_read > > .../media/common/videobuf2/videobuf2-core.c | 9 +++++-- > drivers/media/pci/bt8xx/bttv-driver.c | 27 ++++++++++++++++--- > drivers/media/pci/bt8xx/bttv-vbi.c | 8 +++--- > 3 files changed, 33 insertions(+), 11 deletions(-) > > -- > 2.42.0 > -- -----Open up your eyes, open up your mind, open up your code ------- / Dr. David Alan Gilbert | Running GNU/Linux | Happy \ \ dave @ treblig.org | | In Hex / \ _________________________|_____ http://www.treblig.org |_______/