Hi Hans, Thanks for the review. On Wed, Nov 29, 2023 at 03:26:00PM +0100, Hans Verkuil wrote: > On 29/11/2023 15:15, Sakari Ailus wrote: > > The bus_info field in both struct media_device and struct v4l2_capability > > is assigned by the framework for platform devices. Do not set it in the > > driver. > > That doesn't work for vivid. The problem is that if you create multiple instances > (e.g. modprobe vivid n_devs=2), then each instance will report "platform:vivid.0" > as bus info, but they must give different bus_info names since that has to be unique. > > It should be fine for vimc, though, since that's just a single instance. > > So vivid is an exception to the rule. Rather than removing these snprintf lines, > adding a comment might be better. Sounds reasonable. I'll do this in v2. > > For the record: I tried exactly the same thing myself some time ago, and then > discovered that that didn't fly. -- Sakari Ailus
