Hi Laurent, On Mon 27 Nov 23, 11:07, Laurent Pinchart wrote: > The subdev .init_cfg() operation is affected by two issues: > > - It has long been extended to initialize a whole v4l2_subdev_state > instead of just a v4l2_subdev_pad_config, but its name has stuck > around. > > - Despite operating on a whole subdev state and not being directly > exposed to the subdev users (either in-kernel or through the userspace > API), .init_cfg() is categorized as a subdev pad operation. > > This participates in making the subdev API confusing for new developers. > Fix it by renaming the operation to .init_state(), and make it a subdev > internal operation. > > Signed-off-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> > Acked-by: Michael Riesch <michael.riesch@xxxxxxxxxxxxxx> # for imx415 > Acked-by: Shuah Khan <skhan@xxxxxxxxxxxxxxxxxxx> # for vimc For the sun6i-csi, sun6i-isp, sun6i-mipi-csi2 and sun8i-a83t-mipi-csi2 drivers: Acked-by: Paul Kocialkowski <paul.kocialkowski@xxxxxxxxxxx> I might submit some cosmetic patch later to reorder things but this can wait. Thanks for working on this, it's much cleaner this way :) Cheers, Paul -- Paul Kocialkowski, Bootlin Embedded Linux and kernel engineering https://bootlin.com
Attachment:
signature.asc
Description: PGP signature
