Hi Hans, On Tue, Nov 28, 2023 at 03:55:07PM +0100, Hans Verkuil wrote: > Hi Sakari, > > On 28/11/2023 12:56, Sakari Ailus wrote: > > Hi Mauro, Hans, > > > > Here are a bunch of new drivers (Thine ISP, gc2145 sensor driver, dcmipp > > camera interface driver) and an init_cfg pad op change to init_state > > internal op. Included is also the media tree portion of the DisCo for > > Imaging support and a new fwnode property API function, needed by the Thine > > ISP driver. Also a number of fixes and improvements to the mipid02 and > > vgxy61 drivers are included --- they also depend on the sub-device API > > changes. > > > > Please pull. > > > > > > The following changes since commit 3b8551e73271fc375b15c887db54ad31686eb2ea: > > > > media: wave5: add OF and V4L_MEM2MEM_DRIVERS dependencies (2023-11-24 14:11:22 +0100) > > > > are available in the Git repository at: > > > > git://linuxtv.org/sailus/media_tree.git tags/for-6.8-4-signed > > > > for you to fetch changes up to 710fd99e818be5dc946f689a05971c2a9a1c3b8d: > > > > media: stm32-dcmipp: STM32 DCMIPP camera interface driver (2023-11-28 12:31:47 +0200) > > > > ---------------------------------------------------------------- > > V4L2 patches for 6.8 > > > > ---------------------------------------------------------------- > > Alain Volmat (15): > > dt-bindings: vendor-prefixes: Add prefix for GalaxyCore Inc. > > dt-bindings: media: i2c: add galaxycore,gc2145 dt-bindings > > media: i2c: gc2145: Galaxy Core GC2145 sensor support > > media: i2c: st-mipid02: correct format propagation > > media: i2c: st-mipid02: add usage of v4l2_get_link_freq > > media: i2c: st-mipid02: don't keep track of streaming status > > media: i2c: st-mipid02: use cci_* helpers for register access. > > media: i2c: st-mipid02: use active state to store pad formats > > media: i2c: st-mipid02: use mipi-csi macro for data-type > > media: i2c: st-mipid02: removal of unused link_frequency variable > > media: i2c: st-mipid02: add Y8 format support > > media: i2c: st-vgxy61: Add V4L2_SUBDEV_FL_HAS_EVENTS and subscribe hooks > > media: i2c: st-vgxy61: add v4l2_fwnode ctrls parse and addition > > dt-bindings: media: add bindings for stm32 dcmipp > > media: MAINTAINERS: add entry for STM32 DCMIPP driver > > > > Hugues Fruchet (1): > > media: stm32-dcmipp: STM32 DCMIPP camera interface driver > > I'm getting these kerneldoc warnings/errors in dcmipp-common: > > drivers/media/platform/st/stm32/stm32-dcmipp/dcmipp-common.h:59: error: Cannot parse struct or union! > drivers/media/platform/st/stm32/stm32-dcmipp/dcmipp-common.h:106: warning: Function parameter or member 'pads_flag' not described in 'dcmipp_pads_init' > drivers/media/platform/st/stm32/stm32-dcmipp/dcmipp-common.h:106: warning: Excess function parameter 'pads_flags' description in 'dcmipp_pads_init' > drivers/media/platform/st/stm32/stm32-dcmipp/dcmipp-common.h:147: warning: Function parameter or member 'handler' not described in 'dcmipp_ent_sd_register' > drivers/media/platform/st/stm32/stm32-dcmipp/dcmipp-common.h:147: warning: Function parameter or member 'thread_fn' not described in 'dcmipp_ent_sd_register' > > It is likely best to resolve this in a follow-up patch. Hugues, can you take > a look at that? > > In addition, this PR conflicts with the "[PATCH] media: vsp1: Remove unbalanced > .s_stream(0) calls" vsp1 v6.7 fix: that was merged in mainline yesterday, but this > PR was created without that patch. > > I plan to merge v6.7-rc4 into staging on Monday, so perhaps the best way forward > is if you can apply that fix to your tree, then add the patches from this PR on top > of that, resolving the conflict. Then I can merge the updated PR on Monday. There > are no other issues with this PR, it passed all other tests. I'll send a new version, probably tomorrow, after rebasing on the current media stage tree. -- Regards, Sakari Ailus
