Re: [PATCH v2 1/4] media: v4l2-subdev: Turn .[gs]_frame_interval into pad operations

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 27/11/2023 12:13, Laurent Pinchart wrote:
> The subdev .[gs]_frame_interval are video operations, but they operate
> on pads (and even on streams). Not only is this confusing, it causes
> practical issues for drivers as the operations don't receive a subdev
> state pointer, requiring manual state handling.
> 
> To improve the situation, turn the operations into pad operations, and
> extend them to receive a state pointer like other pad operations.
> 
> While at it, rename the operations to .[gs]et_frame_interval at the same
> time to match the naming scheme of other pad operations. This isn't
> strictly necessary, but given that all drivers using those operations
> need to be modified, handling the rename separately would generate more
> churn for very little gain (if at all).
> 
> Signed-off-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>

Reviewed-by: Hans Verkuil <hverkuil-cisco@xxxxxxxxx>

Regards,

	Hans

> ---
> Changes since v1:
> 
> - Rebase on the latest media tree
> ---
>  drivers/media/i2c/adv7180.c                   |  7 ++-
>  drivers/media/i2c/et8ek8/et8ek8_driver.c      |  6 +-
>  drivers/media/i2c/imx214.c                    |  9 +--
>  drivers/media/i2c/imx274.c                    | 48 +++++---------
>  drivers/media/i2c/max9286.c                   | 14 +++--
>  drivers/media/i2c/mt9m111.c                   | 14 +++--
>  drivers/media/i2c/mt9m114.c                   | 14 +++--
>  drivers/media/i2c/mt9v011.c                   | 18 +++---
>  drivers/media/i2c/mt9v111.c                   | 16 ++---
>  drivers/media/i2c/ov2680.c                    |  7 ++-
>  drivers/media/i2c/ov5640.c                    | 16 ++---
>  drivers/media/i2c/ov5648.c                    | 59 ++++++++---------
>  drivers/media/i2c/ov5693.c                    |  7 ++-
>  drivers/media/i2c/ov6650.c                    | 16 ++---
>  drivers/media/i2c/ov7251.c                    |  6 +-
>  drivers/media/i2c/ov7670.c                    | 18 +++---
>  drivers/media/i2c/ov772x.c                    | 14 +++--
>  drivers/media/i2c/ov7740.c                    | 40 +++++-------
>  drivers/media/i2c/ov8865.c                    | 51 +++++++--------
>  drivers/media/i2c/ov9650.c                    | 14 +++--
>  drivers/media/i2c/s5c73m3/s5c73m3-core.c      | 14 +++--
>  drivers/media/i2c/s5k5baf.c                   | 20 +++---
>  drivers/media/i2c/thp7312.c                   | 22 +++----
>  drivers/media/i2c/tvp514x.c                   | 29 +++------
>  drivers/media/usb/em28xx/em28xx-video.c       |  6 +-
>  drivers/media/v4l2-core/v4l2-common.c         |  8 +--
>  drivers/media/v4l2-core/v4l2-subdev.c         | 63 +++++++++++--------
>  .../media/atomisp/i2c/atomisp-gc0310.c        |  7 ++-
>  .../media/atomisp/i2c/atomisp-gc2235.c        |  7 ++-
>  .../media/atomisp/i2c/atomisp-mt9m114.c       |  7 ++-
>  .../media/atomisp/i2c/atomisp-ov2722.c        |  7 ++-
>  .../staging/media/atomisp/pci/atomisp_cmd.c   |  4 +-
>  .../staging/media/atomisp/pci/atomisp_ioctl.c |  4 +-
>  drivers/staging/media/imx/imx-ic-prp.c        | 14 +++--
>  drivers/staging/media/imx/imx-ic-prpencvf.c   | 14 +++--
>  drivers/staging/media/imx/imx-media-capture.c |  6 +-
>  drivers/staging/media/imx/imx-media-csi.c     | 14 +++--
>  drivers/staging/media/imx/imx-media-vdic.c    | 14 +++--
>  drivers/staging/media/tegra-video/csi.c       |  9 +--
>  include/media/v4l2-common.h                   |  4 +-
>  include/media/v4l2-subdev.h                   | 22 ++++---
>  41 files changed, 348 insertions(+), 341 deletions(-)
> 






[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux