Hi, On 27/11/2023 11:07, Laurent Pinchart wrote:
The subdev .init_cfg() operation is affected by two issues: - It has long been extended to initialize a whole v4l2_subdev_state instead of just a v4l2_subdev_pad_config, but its name has stuck around. - Despite operating on a whole subdev state and not being directly exposed to the subdev users (either in-kernel or through the userspace API), .init_cfg() is categorized as a subdev pad operation. This participates in making the subdev API confusing for new developers. Fix it by renaming the operation to .init_state(), and make it a subdev internal operation. Signed-off-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> Acked-by: Michael Riesch <michael.riesch@xxxxxxxxxxxxxx> # for imx415 Acked-by: Shuah Khan <skhan@xxxxxxxxxxxxxxxxxxx> # for vimc
I didn't go through each and every change in the drivers, but the framework parts look fine, and I didn't see any issues in the driver changes either. So:
Reviewed-by: Tomi Valkeinen <tomi.valkeinen@xxxxxxxxxxxxxxxx> Tomi
