On Tue, Nov 07, 2023 at 04:51:48AM -0500, Umang Jain wrote: > The handle_to_service() helper can return NULL, so `service` pointer > can indeed be set to NULL. So, do not log through service pointer > (which will cause NULL-deference), instead, use the vchiq_instance > function argument to get access to the struct device. > > Fixes: f67af5940d6d("staging: vc04: Convert(and rename) vchiq_log_info() to use dynamic debug") > Signed-off-by: Umang Jain <umang.jain@xxxxxxxxxxxxxxxx> > Reviewed-by: Ricardo B. Marliere <ricardo@xxxxxxxxxxxx> > --- > .../staging/vc04_services/interface/vchiq_arm/vchiq_core.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) Also, please send this as a stand-alone patch so we can apply it for 6.7-final. thanks, greg k-h