On 24/10/2023 21:09, Detlev Casanova wrote: > `false` was used as the keep_bitstream_buffers parameter permissions. > This looks more like a default value for the parameter, so change it to > 0 to avoid confusion. > > Reviewed-by: Daniel Almeida <daniel.almeida@xxxxxxxxxxxxx> > Signed-off-by: Detlev Casanova <detlev.casanova@xxxxxxxxxxxxx> > --- > drivers/media/test-drivers/visl/visl-core.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/media/test-drivers/visl/visl-core.c b/drivers/media/test-drivers/visl/visl-core.c > index 9970dc739ca5..df6515530fbf 100644 > --- a/drivers/media/test-drivers/visl/visl-core.c > +++ b/drivers/media/test-drivers/visl/visl-core.c > @@ -74,7 +74,7 @@ MODULE_PARM_DESC(visl_dprintk_nframes, > " the number of frames to trace with dprintk"); > > bool keep_bitstream_buffers; > -module_param(keep_bitstream_buffers, bool, false); > +module_param(keep_bitstream_buffers, bool, 0); ??? This last parameter is the permission, it makes no sense that this is either 0 or false: then nobody can see it in /sys/modules/. Typically this is 0444 if it is readable only, or 0644 if it can be written by root. Regards, Hans > MODULE_PARM_DESC(keep_bitstream_buffers, > " keep bitstream buffers in debugfs after streaming is stopped"); >
