Hello everyone, > > >> create mode 100644 drivers/media/platform/rockchip/cif/Kconfig > > >> create mode 100644 drivers/media/platform/rockchip/cif/Makefile > > >> create mode 100644 drivers/media/platform/rockchip/cif/capture.c > > >> create mode 100644 drivers/media/platform/rockchip/cif/capture.h > > >> create mode 100644 drivers/media/platform/rockchip/cif/common.h > > >> create mode 100644 drivers/media/platform/rockchip/cif/dev.c > > >> create mode 100644 drivers/media/platform/rockchip/cif/regs.h > > > > > > Just a logigistic comment on my side for now, sorry :) > > > What about use cif-* prefix in front of driver files? > > > > > > like: > > > > > > cif-capture.c > > > cif-capture.h > > > cif-common.h > > > cif-dev.c > > > cif-regs.h > > > > What would be the rationale here? > > > > IMHO the files are in a folder named cif, so adding this prefix seems > > kind of redundant. > > > > That said, if there is a good reason I could live with cif-*.{c,h} as > > well, of course. My only request would be to agree on something ASAP. > > It's rather common to do that in Linux and one advantage is that it makes it > clear in your text editor which driver you are looking at when only the file > name is shown. > > I don't have any strong opinion on this either though. I see that the majority of the drivers are named like suggested. I will change the names in the V12. -- Kind Regards Mehdi Djait