Hi all, I have two questions: 1. When running v4l2-compliance on a proprietary driver, I get this error: ``` Input/Output configuration ioctls: fail: v4l2-test-io-config.cpp(227): fmt.fmt.pix.width >= enumtimings.timings.bt.width * 1.5 fail: v4l2-test-io-config.cpp(386): Timings check failed for input 0. test VIDIOC_ENUM/G/S/QUERY_DV_TIMINGS: FAIL ``` Which brings me here: https://git.linuxtv.org/v4l-utils.git/tree/utils/v4l2-compliance/v4l2-test-io-config.cpp#n227 ``` fail_on_test(fmt.fmt.pix.width < enumtimings.timings.bt.width); fail_on_test(fmt.fmt.pix.width >= enumtimings.timings.bt.width * 1.5); fail_on_test(fmt.fmt.pix.height * factor < enumtimings.timings.bt.height); fail_on_test(fmt.fmt.pix.height * factor >= enumtimings.timings.bt.height * 1.5); ``` The problem is that the driver supports VIDIOC_S_DV_TIMINGS but is not able to apply the specific format just returns the actual timings. This is from what I know, not a violation, so I'm not sure what the driver should return if it is not able to set a custom timing. Or is this check just a bit too strict? 2. For another driver, I get this error: ``` Input ioctls: fail: v4l2-test-input-output.cpp(443): use of deprecated digital video status fail: v4l2-test-input-output.cpp(496): invalid attributes for input 0 test VIDIOC_G/S/ENUMINPUT: FAIL ``` It might be true that setting V4L2_IN_ST_NO_CARRIER is deprecated, but is that really an error, not better to just have it as a warning? After all, how can userspace know specific details if needed? Perhaps checking that V4L2_IN_ST_NO_SIGNAL has also been set is enough, and if V4L2_IN_ST_NO_CARRIER is set, but not V4L2_IN_ST_NO_SIGNAL, then it might be an error. Thx in advance! Kr, Thomas Devoogdt
