Hi Bingbu, On Tue, Nov 21, 2023 at 11:03:06AM +0800, Bingbu Cao wrote: > Sakari, > > On 11/20/23 2:35 PM, Sakari Ailus wrote: > > Hi Bingbu, > > > > On Mon, Nov 20, 2023 at 12:14:40PM +0800, Bingbu Cao wrote: > >> > >> Sakari and others, > >> > >> On 11/6/23 4:35 PM, bingbu.cao@xxxxxxxxx wrote: > >>> From: Bingbu Cao <bingbu.cao@xxxxxxxxx> > >>> > >>> Following Sakari's patch: > >>> <URL:https://lore.kernel.org/linux-media/20231102090752.1418132-1-sakari.ailus@xxxxxxxxxxxxxxx/> > >>> > >>> The sensor device maybe accessible right after its async sub-device is > >>> registered, so runtime PM should be ready before its async sub-device > >>> is registered. > >>> > >>> > >>> Bingbu Cao (4): > >>> media: imx355: Enable runtime PM before registering async sub-device > >>> media: ov01a10: Enable runtime PM before registering async sub-device > >>> media: ov13b10: Enable runtime PM before registering async sub-device > >>> media: ov9734: Enable runtime PM before registering async sub-device > >>> > >>> drivers/media/i2c/imx355.c | 13 ++++++++----- > >>> drivers/media/i2c/ov01a10.c | 7 +++++-- > >>> drivers/media/i2c/ov13b10.c | 14 +++++++++----- > >>> drivers/media/i2c/ov9734.c | 19 +++++++++++-------- > >>> 4 files changed, 33 insertions(+), 20 deletions(-) > >>> > >> > >> Do you have any comments on this series? > > > > Oops. What's the reason for splitting pm_runtime_idle() call from the rest > > of the Runtime PM related setup? > > Ah, no special reason actually. I just want to make the pm idle callback to > be the last ops as it was. I have no idea what the async callback does > before idle. I think it'd best to move it with the rest of the Runtime PM calls. -- Regards, Sakari Ailus
