On 11/6/2023 11:26 AM, Yong Wu (吴勇) wrote: > On Wed, 2023-11-01 at 11:20 +0530, Jaskaran Singh wrote: >> >> External email : Please do not click links or open attachments until >> you have verified the sender or the content. >> On 10/20/2023 3:20 PM, Yong Wu (吴勇) wrote: >>> On Thu, 2023-10-19 at 10:16 +0530, Vijayanand Jitta wrote: >>>> >>>> Instead of having a vendor specific binding for cma area, How >> about >>>> retrieving >>>> >>> >> https://lore.kernel.org/lkml/1594948208-4739-1-git-send-email-hayashi.kunihiko@xxxxxxxxxxxxx/ >>>> ? >>>> dma_heap_add_cma can just associate cma region and create a heap. >> So, >>>> we can reuse cma heap >>>> code for allocation instead of replicating that code here. >>>> >>> >>> Thanks for the reference. I guess we can't use it. There are two >>> reasons: >>> >>> a) The secure heap driver is a pure software driver and we have no >>> device for it, therefore we cannot call dma_heap_add_cma. >>> >> >> Hi Yong, >> >> We're considering using struct cma as the function argument to >> dma_heap_add_cma() rather than struct device. Would this help >> resolve the problem of usage with dma_heap_add_cma()? > > Yes. If we use "struct cma", I guess it works. > Great; I've posted a v2[1] for the API incorporating this change. Thanks, Jaskaran. [1] https://lore.kernel.org/lkml/20231117100337.5215-1-quic_jasksing@xxxxxxxxxxx/