On Fri, Nov 17, 2023 at 07:43:04PM +0100, Hans de Goede wrote: > On 11/8/23 15:10, Andreas Helbech Kleist wrote: > > On Wed, 2023-11-08 at 12:25 +0100, Hans de Goede wrote: > >> On 10/24/23 13:29, bingbu.cao@xxxxxxxxx wrote: ... > ret = pci_alloc_irq_vectors(dev, 1, 1, PCI_IRQ_MSI); > - if (ret) > + if (ret < 0) { > dev_err_probe(&dev->dev, ret, "Request msi failed"); > + return ret; Even further: return dev_err_probe(&dev->dev, ret, "Request msi failed"); > + } -- With Best Regards, Andy Shevchenko