Hi Marek,
Thanks for your patches, I went through your changes. Minor comments below.
On Tue, Oct 19, 2010 at 23:41, Marek Szyprowski
<m.szyprowski@xxxxxxxxxxx> wrote:
> From: Pawel Osciak <p.osciak@xxxxxxxxxxx>
> +/**
> + * __vb2_queue_cancel() - cancel and stop (pause) streaming
> + *
> + * Removes all queued buffers from driver's queue and all buffers queued by
> + * userspace from videobuf's queue. Returns to state after reqbufs.
> + */
> +static void __vb2_queue_cancel(struct vb2_queue *q)
> +{
> + /*
> + * Tell driver to stop all dma transactions and release all queued
> + * buffers
> + */
Just being picky, but those doesn't neccesarily are "dma" transactions.
> + if (q->streaming && q->ops->stop_streaming)
> + q->ops->stop_streaming(q);
> + q->streaming = 0;
> +
> + /*
> + * Remove all buffers from videobuf's list...
> + */
> + INIT_LIST_HEAD(&q->queued_list);
> + /*
> + * ...and done list; userspace will not receive any buffers it
> + * has not already dequeued before initiating cancel.
> + */
> + INIT_LIST_HEAD(&q->done_list);
> + wake_up_all(&q->done_wq);
Any reason for replacing wake_up_interruptible_all with wake_up_all?
--
Best regards,
Pawel Osciak
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
