Re: [PATCH v2 0/2] media: v4l2-subdev: Make .init_cfg() an internal operation

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 11/14/23 06:15, Laurent Pinchart wrote:
Hello,

This patch series addresses a historical issue in the V4L2 subdev
in-kernel API.

The subdev .init_cfg() pad operation used to initialize a
v4l2_subdev_pad_config structure. This was changed to initializing a
v4l2_subdev_state a while ago, but the operation wasn't renamed, and
stayed a pad operation. Not only is the name confusing for new
developers, it is also the only pad operation that doesn't operate on a
pad, leading to more confusion.

This series addresses those two issues by renaming the operation to
.init_cfg() and moving it to the subdev internal operations, in patch
2/2. Most of the preparatory patches from v1 have been applied by Sakari
already, leaving only 1/2 for a respin due to issues with the
first version.

The series is based on a merge oof Sakari's latest pull request for v6.8
([1]) and a v6.7 fix for the VSP1 driver ([2]).

[1] https://lore.kernel.org/linux-media/ZVEyCfzm4ninES6K@xxxxxxxxxxxxxxxxxxxxxx
[2] https://lore.kernel.org/linux-media/20231113020054.GA18039@xxxxxxxxxxxxxxxxxxxxxxxxxx

The VSP1 driver has been tested on a Renesas R-Car M3-N Salvator-XS. The
rest of the series is compile-tested only.

Laurent Pinchart (2):
   media: renesas: vsp1: Fix references to pad config
   media: v4l2-subdev: Rename .init_cfg() operation to .init_state()


  .../media/test-drivers/vimc/vimc-debayer.c    |  11 +-
  drivers/media/test-drivers/vimc/vimc-scaler.c |  11 +-
  drivers/media/test-drivers/vimc/vimc-sensor.c |  11 +-

For vimc:

Acked-by: Shuah Khan <skhan@xxxxxxxxxxxxxxxxxxx>

thanks,
-- Shuah




[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux