Re: [PATCH v2 2/2] media: i2c: Add driver for OmniVision OV64A40

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Jacopo,

kernel test robot noticed the following build warnings:

[auto build test WARNING on 61ab89c1916219ccbeca9f6cefb1680212de8d1c]

url:    https://github.com/intel-lab-lkp/linux/commits/Jacopo-Mondi/media-dt-bindings-Add-OmniVision-OV64A40/20231115-035231
base:   61ab89c1916219ccbeca9f6cefb1680212de8d1c
patch link:    https://lore.kernel.org/r/20231114182831.220823-3-jacopo.mondi%40ideasonboard.com
patch subject: [PATCH v2 2/2] media: i2c: Add driver for OmniVision OV64A40
config: alpha-allyesconfig (https://download.01.org/0day-ci/archive/20231115/202311152102.decxO6op-lkp@xxxxxxxxx/config)
compiler: alpha-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231115/202311152102.decxO6op-lkp@xxxxxxxxx/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202311152102.decxO6op-lkp@xxxxxxxxx/

All warnings (new ones prefixed by >>):

   drivers/media/i2c/ov64a40.c:2808:31: warning: no previous prototype for 'ov64a40_get_timings' [-Wmissing-prototypes]
    2808 | const struct ov64a40_timings *ov64a40_get_timings(struct ov64a40 *ov64a40)
         |                               ^~~~~~~~~~~~~~~~~~~
   drivers/media/i2c/ov64a40.c: In function 'ov64a40_remove':
   drivers/media/i2c/ov64a40.c:3609:25: warning: unused variable 'ov64a40' [-Wunused-variable]
    3609 |         struct ov64a40 *ov64a40 = sd_to_ov64a40(sd);
         |                         ^~~~~~~
   drivers/media/i2c/ov64a40.c: At top level:
>> drivers/media/i2c/ov64a40.c:3175:12: warning: 'ov64a40_power_on' defined but not used [-Wunused-function]
    3175 | static int ov64a40_power_on(struct device *dev)
         |            ^~~~~~~~~~~~~~~~
   drivers/media/i2c/ov64a40.c:119:18: warning: 'ov64a40_link_freq_menu' defined but not used [-Wunused-const-variable=]
     119 | static const s64 ov64a40_link_freq_menu[] = {
         |                  ^~~~~~~~~~~~~~~~~~~~~~


vim +/ov64a40_power_on +3175 drivers/media/i2c/ov64a40.c

  3174	
> 3175	static int ov64a40_power_on(struct device *dev)
  3176	{
  3177		struct v4l2_subdev *sd = dev_get_drvdata(dev);
  3178		struct ov64a40 *ov64a40 = sd_to_ov64a40(sd);
  3179		int ret;
  3180	
  3181		ret = ov64a40_enable(dev);
  3182		if (ret)
  3183			return ret;
  3184	
  3185		/*
  3186		 * The first configuration sequence is pretty long, so we write it
  3187		 * once at power-on time to avoid doing it in consecutive
  3188		 * start_streaming calls.
  3189		 */
  3190		return cci_multi_reg_write(ov64a40->cci, ov64a40_init,
  3191					   ARRAY_SIZE(ov64a40_init), NULL);
  3192	}
  3193	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki




[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux