Hello Alain On Mon, Nov 13, 2023 at 03:57:30PM +0100, Alain Volmat wrote: > Use a copy of the struct v4l2_subdev_format when propagating > format from the sink to source pad in order to avoid impacting the > sink format returned to the application. > > Thanks to Jacopo Mondi for pointing the issue. > ;) > Fixes: 6c01e6f3f27b ("media: st-mipid02: Propagate format from sink to source pad") > Signed-off-by: Alain Volmat <alain.volmat@xxxxxxxxxxx> > Cc: stable@xxxxxxxxxxxxxxx > --- > drivers/media/i2c/st-mipid02.c | 9 +++++++-- > 1 file changed, 7 insertions(+), 2 deletions(-) > > diff --git a/drivers/media/i2c/st-mipid02.c b/drivers/media/i2c/st-mipid02.c > index fa27638edc07..dab14787116b 100644 > --- a/drivers/media/i2c/st-mipid02.c > +++ b/drivers/media/i2c/st-mipid02.c > @@ -770,6 +770,7 @@ static void mipid02_set_fmt_sink(struct v4l2_subdev *sd, > struct v4l2_subdev_format *format) > { > struct mipid02_dev *bridge = to_mipid02_dev(sd); > + struct v4l2_subdev_format source_fmt; > struct v4l2_mbus_framefmt *fmt; > > format->format.code = get_fmt_code(format->format.code); > @@ -781,8 +782,12 @@ static void mipid02_set_fmt_sink(struct v4l2_subdev *sd, > > *fmt = format->format; > > - /* Propagate the format change to the source pad */ > - mipid02_set_fmt_source(sd, sd_state, format); > + /* > + * Propagate the format change to the source pad, taking > + * care not to update the format pointer given back to user > + */ > + source_fmt = *format; > + mipid02_set_fmt_source(sd, sd_state, &source_fmt); Looks good! Reviewed-by: Jacopo Mondi <jacopo.mondi@xxxxxxxxxxxxxxxx> Thanks j > } > > static int mipid02_set_fmt(struct v4l2_subdev *sd, > -- > 2.25.1 >