Hi Laurent,
On Tue, Oct 24, 2023 at 4:56 PM Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> wrote:
> On Tue, Oct 24, 2023 at 4:25 PM Laurent Pinchart
> <laurent.pinchart+renesas@xxxxxxxxxxxxxxxx> wrote:
> > The VSP1 driver uses the subdev .s_stream() operation to stop WPF
> > instances, without a corresponding call to start them. The V4L2 subdev
> > core started warning about unbalanced .s_stream() calls in commit
> > 009905ec5043 ("media: v4l2-subdev: Document and enforce .s_stream()
> > requirements"), causing a regression with this driver.
> >
> > Fix the problem by replacing the .s_stream() operation with an explicit
> > function call for WPF instances. This allows sharing an additional data
> > structure between RPF and WPF instances.
> >
> > Fixes: 009905ec5043 ("media: v4l2-subdev: Document and enforce .s_stream() requirements")
> > Reported-by: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>
> > Closes: https://lore.kernel.org/linux-media/2221395-6a9b-9527-d697-e76aebc6af@xxxxxxxxxxxxxx/
> > Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@xxxxxxxxxxxxxxxx>
>
> Thanks for your patch!
>
> The warning splat is gone, so
> Tested-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
FTR, the warning splat is now in v6.7-rc1, but the fix is not
(not even in linux-next).
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
