Re: [PATCH v15 19/56] media: dvb-core: Do not initialize twice queue num_buffer field

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



W dniu 9.11.2023 o 17:34, Benjamin Gaignard pisze:
The above memset already zeroed all the ctx fields, it is useless
to do it here again.

Signed-off-by: Benjamin Gaignard <benjamin.gaignard@xxxxxxxxxxxxx>

Reviewed-by: Andrzej Pietrasiewicz <andrzej.p@xxxxxxxxxxxxx>

---
  drivers/media/dvb-core/dvb_vb2.c | 3 ---
  1 file changed, 3 deletions(-)

diff --git a/drivers/media/dvb-core/dvb_vb2.c b/drivers/media/dvb-core/dvb_vb2.c
index 3a966fdf814c..167ff82a6fed 100644
--- a/drivers/media/dvb-core/dvb_vb2.c
+++ b/drivers/media/dvb-core/dvb_vb2.c
@@ -167,8 +167,6 @@ int dvb_vb2_init(struct dvb_vb2_ctx *ctx, const char *name, int nonblocking)
memset(ctx, 0, sizeof(struct dvb_vb2_ctx));
  	q->type = DVB_BUF_TYPE_CAPTURE;
-	/**capture type*/
-	q->is_output = 0;
  	/**only mmap is supported currently*/
  	q->io_modes = VB2_MMAP;
  	q->drv_priv = ctx;
@@ -177,7 +175,6 @@ int dvb_vb2_init(struct dvb_vb2_ctx *ctx, const char *name, int nonblocking)
  	q->ops = &dvb_vb2_qops;
  	q->mem_ops = &vb2_vmalloc_memops;
  	q->buf_ops = &dvb_vb2_buf_ops;
-	q->num_buffers = 0;
  	ret = vb2_core_queue_init(q);
  	if (ret) {
  		ctx->state = DVB_VB2_STATE_NONE;





[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux