Em 18-10-2010 13:51, Hans Verkuil escreveu: > On Monday, October 18, 2010 16:55:40 David Ellingsworth wrote: >> OK, I see how this fixes it now.. You added the video_is_registered >> check inside v4l2_open after acquiring the device lock. So while it >> fixes that race it's rather ugly and very difficult to follow. In this >> case, the original code provided an easier to follow sequence. If >> possible it would be nice if v4l2_open and v4l2_unlocked_ioctl relied >> on the device being connected rather than registered. Then this would >> have been a non-issue and it would be much easier to follow. > > I agree that it isn't the prettiest code. My goal is to improve the v4l > core to make such cases easier to handle. But I'm waiting for the next > kernel cycle before I continue with this. > > Working on this driver definitely helped give me a better understanding of > what is involved. > > Regards, > Any conclusion about the locking fixes patch? Cheers, Mauro -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
