Re: [PATCH v14 23/56] media: pci: cx18: Stop direct calls to queue num_buffers field

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



W dniu 31.10.2023 o 17:30, Benjamin Gaignard pisze:
Use vb2_get_num_buffers() to avoid using queue num_buffers field directly.
This allows us to change how the number of buffers is computed in the
future.

Signed-off-by: Benjamin Gaignard <benjamin.gaignard@xxxxxxxxxxxxx>

Reviewed-by: Andrzej Pietrasiewicz <andrzej.p@xxxxxxxxxxxxx>

CC: Sergey Kozlov <serjk@xxxxxxxx>
CC: Abylay Ospan <aospan@xxxxxxxx>
---
  drivers/media/pci/cx18/cx18-streams.c | 5 +++--
  1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/media/pci/cx18/cx18-streams.c b/drivers/media/pci/cx18/cx18-streams.c
index 597472754c4c..cfbc4a907802 100644
--- a/drivers/media/pci/cx18/cx18-streams.c
+++ b/drivers/media/pci/cx18/cx18-streams.c
@@ -104,6 +104,7 @@ static int cx18_queue_setup(struct vb2_queue *vq,
  			    unsigned int *nbuffers, unsigned int *nplanes,
  			    unsigned int sizes[], struct device *alloc_devs[])
  {
+	unsigned int q_num_bufs = vb2_get_num_buffers(vq);
  	struct cx18_stream *s = vb2_get_drv_priv(vq);
  	struct cx18 *cx = s->cx;
  	unsigned int szimage;
@@ -121,8 +122,8 @@ static int cx18_queue_setup(struct vb2_queue *vq,
  	 * Let's request at least three buffers: two for the
  	 * DMA engine and one for userspace.
  	 */
-	if (vq->num_buffers + *nbuffers < 3)
-		*nbuffers = 3 - vq->num_buffers;
+	if (q_num_bufs + *nbuffers < 3)
+		*nbuffers = 3 - q_num_bufs;
if (*nplanes) {
  		if (*nplanes != 1 || sizes[0] < szimage)




[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux