Andy, On 11/8/23 11:32 PM, andriy.shevchenko@xxxxxxxxxxxxxxx wrote: > On Wed, Nov 08, 2023 at 04:00:02PM +0100, Andreas Helbech Kleist wrote: >> On Wed, 2023-11-08 at 14:50 +0000, Cao, Bingbu wrote: > > ... > >> Now we're talking about casts. There is a cast to int32_t, but the rest >> of the code uses the s32/u32 typedefs. I don't know if one or the other >> is recommended for new code, but I think it should at least be >> consistent across the driver. > > s32/u32 are preferable in the kernel code. > > Also if you need to extend the sign bit, we have sign_extendXX() helpers. Ack, thanks. I will walk through the code and fix the casts in the driver. > -- Best regards, Bingbu Cao
