Hi Bingbu, On 11/8/23 15:31, Cao, Bingbu wrote: > Hans, > > ------------------------------------------------------------------------ > BRs, > Bingbu Cao > >> -----Original Message----- >> From: Hans de Goede <hans@xxxxxxxxx> >> Sent: Wednesday, November 8, 2023 8:00 PM >> To: Cao, Bingbu <bingbu.cao@xxxxxxxxx>; linux-media@xxxxxxxxxxxxxxx; >> sakari.ailus@xxxxxxxxxxxxxxx; laurent.pinchart@xxxxxxxxxxxxxxxx >> Cc: andriy.shevchenko@xxxxxxxxxxxxxxx; hdegoede@xxxxxxxxxx; >> ilpo.jarvinen@xxxxxxxxxxxxxxx; andreaskleist@xxxxxxxxx; >> claus.stovgaard@xxxxxxxxx; tfiga@xxxxxxxxxxxx; senozhatsky@xxxxxxxxxxxx; >> tomi.valkeinen@xxxxxxxxxxxxxxxx; bingbu.cao@xxxxxxxxxxxxxxx; Qiu, Tian Shu >> <tian.shu.qiu@xxxxxxxxx>; Wang, Hongju <hongju.wang@xxxxxxxxx> >> Subject: Re: [PATCH v2 00/15] Intel IPU6 and IPU6 input system drivers >> >> Hi Bingbu, >> >> On 10/24/23 13:29, bingbu.cao@xxxxxxxxx wrote: >>> From: Bingbu Cao <bingbu.cao@xxxxxxxxx> >>> >>> This patch series adds a driver for Intel IPU6 input system. >>> IPU6 is the sixth generation of Imaging Processing Unit, it is a PCI >>> device which can be found in some Intel Client Platforms. User can use >>> IPU6 to capture images from MIPI camera sensors. >>> >>> IPU6 has its own firmware which exposes ABIs to driver, and >>> communicates with CSE to do firmware authentication. IPU6 has its MMU >>> hardware, so the driver sets up a page table to allow IPU6 DMA to >>> access the system memory. >>> >>> IPU6 input system driver uses MC and V4L2 sub-device APIs besides V4L2. >> >> I have been testing this on a TigerLake system, a Dell Latitude 9420 with >> ov01a1s and the packed 10 bit bayer pixel fmt: V4L2_PIX_FMT_SGRBG10P, which >> libcamera together with (WIP) software debayer support picks by default >> does not work. There are many many CSI errors in dmesg and only the first >> 10 or so lines of the image show. >> >> Disabling the packed format by removing it from ipu6_isys_pfmts[], making >> libcamera pick the unpacked (every 10 bits per pixel data stored in a 16 >> bit word in output buffer) fixes this. >> >> Are the packed bayer formats supposed to work on Tiger Lake, or is this a >> known issue which Intel's own userspace stack avoids by always picking the >> unpacked format ? > > Thanks for the test. > > I remember I verified SGRBG10P format on my ADL device before, but I have > not tested that for a while, give me some time to test again and come back. I can confirm that SGRBG10P works on Alderlake it appears to be broken on Tiger Lake though. Regards, Hans
