On Wed, Nov 08, 2023 at 12:25:19PM +0100, Hans de Goede wrote: > On 10/24/23 13:29, bingbu.cao@xxxxxxxxx wrote: ... > > + ret = pci_alloc_irq_vectors(dev, 1, 1, PCI_IRQ_MSI); > > This does not work on TGL systems (and is not reached on ADL and RPL). > > The out of tree driver instead uses: > > ret = pci_enable_msi(dev); > > and that does work correctly on TGL. Does it mean TGL uses legacy IRQ? In that case we need to simply change the flag to allow that as the used API is what documentation says needs to be used and pci_enable_msi() is deprecated. -- With Best Regards, Andy Shevchenko
