Re: [PATCH v2] media: v4l2-subdev: Fix a 64bit bug

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Nov 03, 2023 at 09:46:11AM +0200, Tomi Valkeinen wrote:
> On 03/11/2023 09:39, Dan Carpenter wrote:
> > - #define V4L2_SUBDEV_CLIENT_CAP_STREAMS		(1U << 0)
> > + #define V4L2_SUBDEV_CLIENT_CAP_STREAMS		(1ULL << 0)
> >   /**
> >    * struct v4l2_subdev_client_capability - Capabilities of the client accessing
> 
> Good catch, thanks! One would wish that the compiler would give a warning on
> cases like this... How did you find this?

This was an unpublished Smatch warning.  I have a comment in my code
that I didn't publish this because Sparse already had a warning for
this.  But that seems not to be true.

I'll clean that up a bit and publish it.  Thanks!

regards,
dan carpenter





[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux