Hi Laurent, On Tue, Oct 24, 2023 at 12:40:04AM +0300, Laurent Pinchart wrote: > Hello, > > This series is the result of me getting bothered by the following note > in the documentation of the v4l2_subdev_pad_config structure: > > * Note: This struct is also used in active state, and the 'try' prefix is > * historical and to be removed. > > So I decided to drop the prefix. > > Patches 1/7 to 6/7 replace direct usage of the fields in drivers with > the corresponding accessor functions. There was a relatively large > number of them in sensor drivers (in 6/7), but more worryingly, the > atmel-isi (1/7), microchip-isc (2/7) and tegra-video (5/7) should really > not have messed up with creating a v4l2_subdev_pad_config structure > manually. I urge the maintainers of those drivers to address the issue. > > Finally, patch 7/7 renames the fields, which becomes easy after > addressing all the drivers. > > The patches have been compile-tested only. > > Sakari, this conflicts with your "[PATCH v3 0/8] Unify sub-device state > access functions" series. I don't mind rebasing on top if it gets merged > first. Thanks for the set, it's really nice. I missed there were so many drivers still accessing this information directly --- I rather thought we always had the access functions to do that, and all drivers used those. I see you've already rebased v2 on top of the cleanups, I'll take these then. -- Regards, Sakari Ailus
