Hi,
On 23. 10. 23 18:05, Arnd Bergmann wrote:
From: Arnd Bergmann <arnd@xxxxxxxx>
As this is just a regular device driver, it has no business force-enabling
other drivers in the system, it should be entirely independent of the
implementation of the spi-nor layer or the specific DMA engine.
The drivers are required for IP cores that are used on the card (in the
FPGA). Without I2C_XILINX and XILINX_XDMA the card won't work at all.
Without SPI_XILINX the access to the card's FLASH (used e.g. for FW
changes) won't be possible.
A change to "depend" instead of "select" is thus possible if it makes
more sense to you, but removing it would make the module not compile or
not work at runtime (there is no symbol dependency to I2C_XILINX and
SPI_XILINX, but both need to be present and are loaded using
request_module() at runtime).
M.
The IIO symbols that are selected here are library modules that
are legitimately used.
Fixes: 0ab13674a9bd ("media: pci: mgb4: Added Digiteq Automotive MGB4 driver")
Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>
---
drivers/media/pci/mgb4/Kconfig | 4 ----
1 file changed, 4 deletions(-)
diff --git a/drivers/media/pci/mgb4/Kconfig b/drivers/media/pci/mgb4/Kconfig
index f2a05a1c8ffa..b90347c7f19b 100644
--- a/drivers/media/pci/mgb4/Kconfig
+++ b/drivers/media/pci/mgb4/Kconfig
@@ -6,10 +6,6 @@ config VIDEO_MGB4
select VIDEOBUF2_DMA_SG
select IIO_BUFFER
select IIO_TRIGGERED_BUFFER
- select I2C_XILINX
- select SPI_XILINX
- select MTD_SPI_NOR
- select XILINX_XDMA
help
This is a video4linux driver for Digiteq Automotive MGB4 grabber
cards.
