Re: [PATCH 2/4] media: i2c: imx214: Move controls init to separate function

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Andre
On Mon, Oct 23, 2023 at 11:49 PM André Apitzsch <git@xxxxxxxxxxx> wrote:
>
> Code refinement, no functional changes.
>
> Signed-off-by: André Apitzsch <git@xxxxxxxxxxx>

With Jacopos comments (don't use de_err_probe())
Reviewed-by: Ricardo Ribalda <ribalda@xxxxxxxxxxxx>

> +       ret = imx214_ctrls_init(imx214);
> +       if (ret < 0)
>                 goto free_ctrl;

It seems like we can mutex_destroy a non inited mutex. Could you send
a follow-up patch to fix that?

Thanks!




[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux