Hi Hans,
On Thu, Oct 26, 2023 at 09:35:55AM +0200, Hans Verkuil wrote:
> On 26/10/2023 09:03, Sakari Ailus wrote:
> > Return NULL from sub-device pad state access functions
> > (v4l2_subdev_state_get_{format,crop,compose}) for non-existent pads. While
> > this behaviour differs from older set of pad state information access
> > functions, we've had a WARN_ON() there for a long time and callers also do
> > validate the pad index nowadays. Therefore problems are not expected.
>
> Huh? Patch 2 adds the WARN_ON, and it is removed in patch 8 again?
>
> I'm really confused.
Patch two makes the generic subdev state information access functions do
exactly what the subdev state pad-specific information access functions
did. As we're merging two classes of users, doing one thing at a time is
prudent.
This patch aligns the behaviour of the single set of subdev state access
functions. Should there a problem there, we can just revert this one.
--
Regards,
Sakari Ailus
