Hi Bingbu, On Thu, Oct 26, 2023 at 11:38:14AM +0800, Bingbu Cao wrote: > Sakari, > > Thanks for the review. > > On 10/25/23 8:09 PM, Sakari Ailus wrote: > > Hi Bingbu, > > > > Thanks for the patch. It's a nice piece of documentation for the most > > complex CSI-2 receiver driver. :-) > > > > On Tue, Oct 24, 2023 at 07:29:24PM +0800, bingbu.cao@xxxxxxxxx wrote: > >> From: Bingbu Cao <bingbu.cao@xxxxxxxxx> > >> > >> Add a documentation for an overview of IPU6 hardware and describe the main > >> the components of IPU6 driver. > >> > >> Signed-off-by: Bingbu Cao <bingbu.cao@xxxxxxxxx> > >> --- > >> .../driver-api/media/drivers/index.rst | 1 + > >> .../driver-api/media/drivers/ipu6.rst | 205 ++++++++++++++++++ > >> 2 files changed, 206 insertions(+) > >> create mode 100644 Documentation/driver-api/media/drivers/ipu6.rst > >> > >> diff --git a/Documentation/driver-api/media/drivers/index.rst b/Documentation/driver-api/media/drivers/index.rst > >> index c4123a16b5f9..7f6f3dcd5c90 100644 > >> --- a/Documentation/driver-api/media/drivers/index.rst > >> +++ b/Documentation/driver-api/media/drivers/index.rst > >> @@ -26,6 +26,7 @@ Video4Linux (V4L) drivers > >> vimc-devel > >> zoran > >> ccs/ccs > >> + ipu6 > >> > >> > >> Digital TV drivers > >> diff --git a/Documentation/driver-api/media/drivers/ipu6.rst b/Documentation/driver-api/media/drivers/ipu6.rst > >> new file mode 100644 > >> index 000000000000..2685e4a0d7ba > >> --- /dev/null > >> +++ b/Documentation/driver-api/media/drivers/ipu6.rst > >> @@ -0,0 +1,205 @@ > >> +.. SPDX-License-Identifier: GPL-2.0 > >> + > >> +================== > >> +Intel IPU6 Driver > >> +================== > >> + > >> +Author: Bingbu Cao <bingbu.cao@xxxxxxxxx> > >> + > >> +Overview > >> +========= > >> + > >> +Intel IPU6 is the sixth generation of Intel Image Processing Unit used in some > >> +Intel Chipsets such as Tiger Lake, Jasper Lake, Alder Lake, Raptor Lake and > >> +Meteor Lake. IPU6 consists of two major systems - Input System (IS) and > > > > I'd use a semicolon: ^ > > semicolon or colon? :) A colon, yes, indeed. -- Regards, Sakari Ailus